ext/sockets: socket_recvfrom() improve error message when port argument is missing #20069
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Oct 5, 2025
TimWolla
reviewed
Oct 5, 2025
Girgias
force-pushed
the
sockets-wrong-count
branch
from
d466fba to
cbbd9b0
Compare
Girgias
force-pushed
the
sockets-wrong-count
branch
from
cbbd9b0 to
9cd7fcf
Compare
devnexen
reviewed
Oct 13, 2025
| if (arg6 == NULL) { | ||
| zend_string_efree(recv_buf); | ||
| WRONG_PARAM_COUNT; | ||
| zend_throw_exception( |
There was a problem hiding this comment.
not a bad idea. zend_argument_count_error could have been used too but you avoid 1 allocation at least.
There was a problem hiding this comment.
I guess, but the thing I found confusing about that API is that it doesn't automatically prefix the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract sockets changes from #20066